Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

优化SinglePHP.class.php兼容性 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

优化SinglePHP.class.php兼容性 #1

wants to merge 1 commit into from

Conversation

nly
Copy link

@nly nly commented Mar 27, 2014

优化

leo108
leo108 reviewed Mar 27, 2014
View reviewed changes
SinglePHP.class.php
@@ -32,7 +32,7 @@ function C($key,$value=null){
halt('传入参数不正确');
}
}
return null;
return true;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处为何要return true？获取不存在的设置应该返回null更合理些吧

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

理一下，此处返回的是新增配置成功的返回值~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkjw youkjw youkjw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nly @leo108 @youkjw